Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing changeset #7337

Merged
merged 5 commits into from
Nov 29, 2024
Merged

chore: add missing changeset #7337

merged 5 commits into from
Nov 29, 2024

Conversation

FRSgit
Copy link
Contributor

@FRSgit FRSgit commented Nov 29, 2024

No description provided.

@FRSgit FRSgit self-assigned this Nov 29, 2024
@FRSgit FRSgit requested a review from a team as a code owner November 29, 2024 10:10
Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: 902ff20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vue-storefront/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FRSgit FRSgit force-pushed the chore/loosen-up-eslint-rules branch from 0e28bf5 to 1bf09de Compare November 29, 2024 10:12
"@vue-storefront/eslint-config": minor
---

**[CHANGED]** some rules to loose up linting a bit (non-breaking)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add precise info what rules has changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done 902ff20

Copy link
Collaborator

@bartoszherba bartoszherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRSgit I approve upfront but please, add info what rules has changed and how

Copy link

sonarcloud bot commented Nov 29, 2024

@FRSgit FRSgit merged commit 0b67c7c into main Nov 29, 2024
2 checks passed
@FRSgit FRSgit deleted the chore/loosen-up-eslint-rules branch November 29, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants